Extended magnetic mapping #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This my crude attempt to allow mapping between rho_pol_norm <-> rho_tor_norm - This also includes phi - I qualitatively tested rho_pol_norm -> rho_tor_norm - Might have some COCOS issues - Probably overly complicated - Needs dynamic fetching of `phi` and `rho_pol_norm`
|
I see this PR is labeled as WIP, so ignoring for now. |
- Tested against mapping form OMFITprofiles - Results are OK by eye. Numerical verification still pending.
odstrcilt
reviewed
Feb 16, 2023
omas/omas_physics.py
Outdated
| from scipy.interpolate import InterpolatedUnivariateSpline | ||
| psi_grid = ods["equilibrium"]["time_slice"][time_index]["profiles_1d"]["psi"] | ||
| psi_mask = mask_SOL(ods, time_index, psi_grid) | ||
| phi_grid = ods["equilibrium"]["time_slice"][time_index]["profiles_1d"]["psi"][psi_mask] |
There was a problem hiding this comment.
This looks like a bug using this definition, phi_grid = psi_grid[psi_mask]
odstrcilt
reviewed
Feb 16, 2023
omas/omas_physics.py
Outdated
| + ods["equilibrium"]["time_slice"][time_index]["global_quantities"]["psi_axis"]) | ||
| elif origin == "rho_tor_norm": | ||
| phi = values**2 | ||
| phi *= np.array([ods["equilibrium"]["time_slice"][time_index]["global_quantities"]["psi_boundary"]]) / np.max(phi) |
There was a problem hiding this comment.
Phi is normalized or real poloidal flux? Because you should multiply it by phi_boundary not by psi_boundary
also, why are you normalizing it by np.max(phi)? What it somebody use as values rho_tor = 0.5? It will force it to be one, always.
odstrcilt
reviewed
Feb 16, 2023
omas/omas_physics.py
Outdated
| psi_spl = InterpolatedUnivariateSpline(phi_grid, psi_grid[psi_mask]) | ||
| phi_min = np.min(phi_grid) | ||
| phi_max = np.max(phi_grid) | ||
| values_mask = np.logical_ant(values > phi_min, values < phi_max) |
There was a problem hiding this comment.
np.logical_ant(values > phi_min, values < phi_max) is the same as (values > phi_min)&(values < phi_max)
There was a problem hiding this comment.
I literally put a bug in this line xD (a logical ant to be specific)
- Results seem good now
|
Stale pull request message |
AreWeDreaming
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phiandrho_pol_norm